Neeraj Hotfix Restore Job Analytics Graph Data Rendering#4722
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Neeraj-Kondaveeti
added
the
High Priority - Please Review First
Neeraj-Kondaveeti
changed the title
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Neeraj,
Well done with this implementation.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Neeraj,
I have reviewed your PR locally and it does work as expected. I would like to point out that in dark mode the calendar is in light mode which reviewers might point out during merge.
Ganesh112001
left a comment
Ganesh112001
left a comment
There was a problem hiding this comment.
I tested PR #4722 and verified that the Job Analytics graph data rendering fix works perfectly. After navigating to /job-analytics-competitive-roles, the horizontal bar chart displays correctly showing "Most Competitive Roles" with proper data instead of the previous "No data available" error. The graph renders roles sorted from most to least competitive (Master Electrician, Surveyor, Video Producer, Food Specialist, Graphic Designer) with accurate application counts and data labels on bars. All filters work correctly including date filter, role filter, and time granularity toggle (Weekly, Monthly, Annually). Data normalization functions properly and the graph updates appropriately based on filter selections. No console errors observed. Everything works perfectly and is ready for merge!
sundarmachani
left a comment
sundarmachani
left a comment
There was a problem hiding this comment.
I have tested this PR locally and verified that the Job Analytics Competitive Roles graph now renders correctly with valid backend data. The regression where the chart showed “No data available” is resolved, and the defensive normalization correctly handles variations in backend response shapes without affecting existing filters, aggregation logic, or visual presentation. I confirmed that application counts are derived safely and that valid datasets are no longer filtered out incorrectly. I also validated the behavior across different role, date range, and granularity filters, and the chart updates as expected in all cases. Before and after screenshots were captured to confirm the fix. This looks good to merge as a frontend hotfix to restore the expected functionality.
Before:
After:
saitejakaasoju
left a comment
saitejakaasoju
left a comment
There was a problem hiding this comment.
Hi Neeraj,
I tested PR #4722 and confirmed the Job Analytics Competitive Roles graph now renders correctly with valid data, resolving the previous “No data available” issue. All filters (date, role, and time granularity) work as expected, data normalization is solid, no console errors observed, and the chart is ready to merge.
|
Thank you all, merging! |
7 participants
Description
This PR fixes a regression on the Job Analytics Competitive Roles page where the graph displayed “No data available” after the previous merge, despite valid backend data being present. The issue was caused by frontend handling of backend response variations, which led to valid data being normalized to zero and filtered out before rendering. This change restores the expected behavior by defensively normalizing the response data prior to chart rendering without altering existing filters, aggregation logic, or visual presentation.
Related PRS (if any):
This frontend PR is related to the Development Backend branch.
This PR is hot fix for the frontend PR : #4010
…
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Note: